Author Topic: 1.2.5.12  (Read 18888 times)

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
1.2.5.12
« on: October 16, 2013, 01:44:13 am »
http://www.aqua-mail.com/download/AquaMail-market-1.2.5.12.apk

This has been requested a lot:

+ Phone numbers in messages are now clickable links.

The app now has to parse HTML content inside messages. I'm sure some particularly nasty (malformed) messages, broken in ways that I've not seen yet, can cause my HTML lexer to malfunction.

In this case, please send the original source of such messages to kmansoft / gmail / dot com as attachments. Original message sources are easy to obtain in web mail (GMail and others) or most desktop mail apps.

As an alternative, please enable debug logging with "session data" enabled, then open a message and use Menu / Diag: reload (last item) to record its contents in the app's own debug log. Then send the debug log to the address above.

Positive side effects:

1 - Two panel animations when opening a message are now smother. To make them as smooth as I'd like, still need to get rid of Android's built-in TextView objects inside each message item layout. However, I see an improvement in this version on my 2012 Nexus 7 and 2011 Acer A100.

2 - Replying to a message that has HTML content and no plain text content, causing the latter to be extracted from the former... no longer causes a long pause. HtmlCleaner is a fantastic library, just not written with mobile devices in mind... glad I don't have to use it anymore.

And now for my Russian users:

+ Телефонные номера в сообщениях теперь работают по нажатию как ссылки.

Для этого программе приходится делать полный лексический разбор HTML сообщений.

Очень вероятно, что найдутся кривые сообщения, на которых этот код будет неверно работать.

В таком случае - прошу слать исходники проблемных сообщений на kmansoft / собака / gmail / точка com. Исходники можно получить в веб-почте (gmail, yandex, mail.ru, rambler) или в почтовой программе. Также можно включить собственный отладочный лог, с записью данных сессии, и открыв письмо, сделать Меню / перезагрузить (последний пункт).

Также, как побочные эффекты:

1) стали более плавными анимации двух-панельного режима при открытии сообщения (хотя для полного счастья, еще нужно выкинуть Андроидные TextView из списка сообщений) и

2) при ответе на письмо, в котором только HTML и нет простого текста, то есть его нужно извлекать из HTML, пропали значительные задержки на эту процедуру (HtmlCleaner - наверное, прекрасная библиотека, но производительность - явно не для мобильных устройств...)
« Last Edit: October 18, 2013, 02:31:39 am by Kostya Vasilyev, Aqua Mail »
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

fatappel

  • Newbie
  • *
  • Posts: 9
Re: 1.2.5.12
« Reply #1 on: October 17, 2013, 06:14:39 pm »
Everything working well but get force close and unable to open if in a no service area.  Only able to use if switch to airplane mode in no service areas

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #2 on: October 18, 2013, 12:34:01 am »
Hello,

Thanks, yes, I'm gradually becoming aware of this issue... The networking code did change a bit (for EWS)...

So far I'm unable to reproduce the issue on my devices. Do you think it would be possible for you to capture the issue in a debug log and email it to me, as described below?

http://www.aqua-mail.com/?page_id=232

This would really help me fix the issue. Thanks in advance!
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #3 on: October 18, 2013, 12:40:04 am »
Never mind - I just got a debug log from someone else and was able to fix the issue.

Will post a new build on the forum tonight.
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

druckmusik

  • Newbie
  • *
  • Posts: 29
Re: 1.2.5.12
« Reply #4 on: October 18, 2013, 09:41:12 am »
http://www.aqua-mail.com/download/AquaMail-market-1.2.5.12.apk

This has been requested a lot:

+ Phone numbers in messages are now clickable links.


Nice feature, but is there any chance to get an option
to disable this behavior?
Not only phone numbers are clickable, lots of other
numbers are too.


Stefran

jcasares

  • Full Member
  • ***
  • Posts: 245
Re: 1.2.5.12
« Reply #5 on: October 18, 2013, 02:46:52 pm »
Didn't upgrade yet but seems annoying as you say if every number out there gets a link. :P

druckmusik

  • Newbie
  • *
  • Posts: 29
Re: 1.2.5.12
« Reply #6 on: October 18, 2013, 03:04:33 pm »
Didn't upgrade yet but seems annoying as you say if every number out there gets a link. :P

Not ALL numbers, but a lot.
I get a lot of Mails with numeric data.
e.g.
10-000802b4ddea (here 10-000802 is recognized as telephone number)
10-000802b57507 (here 10-000802 and 57507 are recognized as telephone numbers)

But a date, e.g. 2013 is not recognized as telephone number.


Stefan

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #7 on: October 19, 2013, 02:01:21 am »
It's difficult to avoid false positives when detecting phone numbers.

People write things like:

Call me at 123-456, and do it soon (comma).
My number is 123-456. (period)
They might forget to types spaces where needed.
Etc, etc etc.

Is there a real issue here, or is it just "the app doesn't read the sender's mind"?
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

beaky

  • Full Member
  • ***
  • Posts: 169
Re: 1.2.5.12
« Reply #8 on: October 19, 2013, 02:09:51 am »
Well, my tablet has no phone. It would be nice to turn off the feature in settings, or to recognise somehow there is no phone. I appreciate that I just might want to add it to the people app or a calendar app, but up till now I have not done this more than a handful of times....

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #9 on: October 19, 2013, 02:11:17 am »
Ah, of course! Thanks, that's something I didn't think about!
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #10 on: October 19, 2013, 02:28:32 am »
Well, that didn't work out...

A device without real telephone hardware may have SIP VOIP, and my Nexus 7 reports it has it, even though I don't have any SIP software.

Let's see.

I'll try to crank down on false positives, my idea is to check the preceding / succeeding characters and only allow things like spaces and punctuation. This should handle the "10-000802b4ddea" etc.

If that's still not good enough, I'll consider a setting as a way to turn the whole thing off.
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

beaky

  • Full Member
  • ***
  • Posts: 169
Re: 1.2.5.12
« Reply #11 on: October 19, 2013, 02:48:08 am »
Well, that didn't work out...

A device without real telephone hardware may have SIP VOIP, and my Nexus 7 reports it has it, even though I don't have any SIP software.

Let's see.

I'll try to crank down on false positives, my idea is to check the preceding / succeeding characters and only allow things like spaces and punctuation. This should handle the "10-000802b4ddea" etc.

If that's still not good enough, I'll consider a setting as a way to turn the whole thing off.

Good point about the VoIP. Never thought of that.

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #12 on: October 19, 2013, 02:54:28 am »
@beaky, @jcasares - please try this new build:

http://www.aqua-mail.com/forum/index.php?topic=1705.0

Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

jcasares

  • Full Member
  • ***
  • Posts: 245
Re: 1.2.5.12
« Reply #13 on: October 19, 2013, 03:14:38 am »
Attached some examples with the new version.

Failed with an IP, a MAC address and a date in one way of formatting it.
Didn't fail with IDs used here that is a good thing.

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: 1.2.5.12
« Reply #14 on: October 20, 2013, 02:25:24 am »
Hello,

IP addresses, IMEI's, dates separated by dots look just like phone numbers.

Maybe I can add another check for the IP address case, where digits continue after a dot.

Mac addresses separated by dashes also look like phone numbers. It's more common to write them with ":"-s.

So far I've had very positive feedback to this feature, even before last night's false positive improvement.

On the other hand, it seems that you, @jcasares and @beaky, do not like it.

It's never going to be perfect.. digits are digits, they're used for far more than phone numbers.

Should I provide a way to turn this off entirely?
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/