Night mode doesn't activate on Friday

[sfgreenwood]

I have night node activated Monday - Friday 2000-0800 and weekends set as Saturday and Sunday 0000 - 2359 with 'Shift night mode' checked. Alerts aren't switched off on Friday evenings between 2000 and 2359. Everything works fine every other day of the week.

Motorola Moto G (3rd Generation)
Android 6.0

[Kostya Vasilyev]

I have night node activated Monday - Friday 2000-0800 and weekends set as Saturday and Sunday 0000 - 2359 with 'Shift night mode' checked. Alerts aren't switched off on Friday evenings between 2000 and 2359. Everything works fine every other day of the week.

I'll have to sit down and think what the above settings really mean, the "shift night mode" has special cases for Friday and Sunday night "the night before the weekend" and "the last night of the weekend", to better fit with what "weekends" mean:

- Night mode, 10pm-8am (say)
- Sat, Sun, "shift" to 11pm-10am, non-working days, usual to go to bed later and to get up later

What this will do is:

- On Friday, the "enter night mode" will be 11pm, even though it's still Friday -- because the *next* day is the weekend (Saturday), and so it's expected that "the user" will go to bed later on Friday night (and get up later on Saturday).

- On Sunday, the "enter night mode" will be 10pm, even though it's still Saturday -- because the *next* day is not the weekend anymore (Monday), so it's expected that "the user" will go to bed earlier on Sunday night, to get up early on Monday.

Now the night mode not kicking in at all is a bug. I will write it down to investigate (fortunately, I've got very detailed unit tests for night mode logic).

But I also would like to suggest using "all day" for your weekend days, not "shift night mode", since it seems to fit what you're actually trying to do.

[mikeone]

Kostya:
Thanks a lot for your explanation.

But I assume there is minor "typo" within your description:

- On Sunday, the "enter night mode" will be 10pm, even though it's still Saturday Sunday -- because the *next* day is not the weekend anymore (Monday), so it's expected that "the user" will go to bed earlier on Sunday night, to get up early on Monday.

[Kostya Vasilyev]

Yes, typo. Sorry.

[Kostya Vasilyev]

I better understand the logic, so it's not a bug, but is worth a change to fit what I (and obviously other people) understand by weekend nights.

I never used the term "weekend night".

It just wouldn't make sense to make it work so that you get a late "start silent mode" on a Sunday -- because typically there will be an early (earlier) "resume sound" on Monday, the day after the weekend.

[StR]

Kostya, let me play devil's advocate. Your logic works when you think about sleep schedule. But some people think from the work schedule.
Here is a use case for that :
For people who work on weekends but on a different schedule, e.g. shorter hours on weekend (say 11-5pm vs. 9am-7pm on weekdays), it would mean that Saturday and Sunday night, they can stop watching their business e-mails earlier (still full day Friday evening).

[sfgreenwood]

Your suggestions make sense, I wasn't really sure of what 'Shift night mode' did but I see now so that should hopefully fix it.

[Kostya Vasilyev]

Re: Kostya, let me play devil's advocate. Your logic works when you think about sleep schedule. But some people think from the work schedule.

Yes it's true, I'm aware of it.

Well, let's see, I've entered this into the bug tracker and spent some time looking at it, but the code is from 2012 so I'll need a bit more time (also there weren't any complaints before, this is the first one).