Author Topic: open a http link from the mail  (Read 8515 times)

paulkatto

  • Newbie
  • *
  • Posts: 5
open a http link from the mail
« on: December 02, 2012, 06:19:51 pm »
it seems as if links are not higlighted within text mails. I believe this happens only in plain text mails (html mail style links work though). Would be nice if links would be clcikable in text mails as well!

Paul

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: open a http link from the mail
« Reply #1 on: December 04, 2012, 03:23:27 am »
Paul,

In general, they are, the app searches for links and uses HTML <a>'s to make them clickable.

Does your link have any unusual characters? I'm thinking my regular expression may be not handling some cases.

Simple links ("http://www.foo.bar") should work through, I know they do for me, can you check that too, so we know what we're dealing with?
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

paulkatto

  • Newbie
  • *
  • Posts: 5
Re: open a http link from the mail
« Reply #2 on: December 04, 2012, 11:01:48 pm »
mh... looking at it a little bit closer, it's html and even yahoo mail does not show it as a clickable link (MS exchange does though).

Can't attach the mail source here ("not allowed to post external links"), take a look at the text file attachment, hope that works.

Cheers,

 Paul


Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: open a http link from the mail
« Reply #3 on: December 07, 2012, 03:17:03 am »
Thanks for the message.

Yes, it's HTML, and the "http://<blah>" is there, but there is no <a> element.

The sending app should have wrapped the link in an <a>...
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

paulkatto

  • Newbie
  • *
  • Posts: 5
Re: open a http link from the mail
« Reply #4 on: December 07, 2012, 07:16:29 pm »
this is a mail coming from hotmail, don't know what the sender did wrong :)

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: open a http link from the mail
« Reply #5 on: December 08, 2012, 03:24:16 am »
Ok, tried this with my Hotmail account.

There are two ways to insert links.

One is to just type them in, this does not wrap the link in the appropriate HTML markup "<a>", so it just stays plain text, and is not clickable in AquaMail.

The other is to use the "link" icon in the tool bar. This inserts an anchor "<a>" which is then clickable.

I believe Hotmail should scan for and convert all links, but...

...I'll see if I can make the app detect links without an enclosing anchor and highlight them.
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

jcasares

  • Full Member
  • ***
  • Posts: 245
Re: open a http link from the mail
« Reply #6 on: January 08, 2013, 05:23:12 pm »
...I'll see if I can make the app detect links without an enclosing anchor and highlight them.
As an option please. :P

Saiph

  • Newbie
  • *
  • Posts: 1
Re: open a http link from the mail
« Reply #7 on: February 20, 2013, 12:04:11 pm »
First of all, thank you for the great app!

I have one suggestion though. Can you please include square brackets in the set of allowed URL characters?
I have a plain-text e-mail with the following URL (slashes inverted to trick the forum's URL filter): http:\\www.paczkomaty.pl/sledzenie_paczki,34.html?package[1]=631043050380388019904447. The link is detected but the part starting with [1] is excluded, while the only thing that actually should be excluded is the dot at the end.
RoundCube for example handles this correctly.

paulkatto

  • Newbie
  • *
  • Posts: 5
Re: open a http link from the mail
« Reply #8 on: March 02, 2013, 09:39:42 pm »
Hey, just downloaded the latest update and there is the html higlhlighting feature! Very nice, well done and thanks for hacking it in!

Paul

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: open a http link from the mail
« Reply #9 on: March 07, 2013, 02:39:36 am »
Cool.

Those who say that HTML can't be parsed with regular expressions are obviously wrong :)

( I know, I know, this is sooo wrong.... .will work towards a better parser.... to highlight phone numbers.... at some point... )
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/