Author Topic: Vsn 1.6.0.10 overwrites Firefox tab when click on url  (Read 9411 times)

Marti

  • Newbie
  • *
  • Posts: 24
Vsn 1.6.0.10 overwrites Firefox tab when click on url
« on: February 02, 2016, 11:01:44 pm »
I couldn't find this problem in the forum.  I have just set up AquaMail for my Gmail account because I like the rich text capability. However, when I click on a url in a message, AquaMail overwrites my current FireFox tab. Clicking on the same URL in the same messages from my Gmail app works fine. Help!

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #1 on: February 02, 2016, 11:07:59 pm »
You must have opened a link from AquaMail and then kept browsing in this tab to some other site -- but to the web browser, this link is "remembered as" having been opened from AquaMail.

By Android convention, when you clicked on a link in AquaMail, it's supposed to open in this already "remembered as opened from AquaMail" tab if any.

( at least that's how it's supposed to work and works with Chrome and standard Android browser, I don't use Firefox ).

Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

StR

  • Hero Member
  • *****
  • Posts: 1558
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #2 on: February 03, 2016, 01:13:17 am »
By Android convention, when you clicked on a link in AquaMail, it's supposed to open in this already "remembered as opened from AquaMail" tab if any.

( at least that's how it's supposed to work and works with Chrome and standard Android browser, I don't use Firefox ).
I am primarily using Opera (on Motorola's Droid Razr M + Android 4.1.2). I know for sure that with the weather gadget that came with the phone, when I click on "details", it opens accuweather.com page - each time in a new tab.
But I have seen the behavior as you described -- don't remember if it was with Opera or with Chrome.


Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #3 on: February 03, 2016, 01:28:39 am »
http://developer.android.com/intl/ru/reference/android/provider/Browser.html#EXTRA_APPLICATION_ID

Quote
The value is a unique identification string that will be used to identify the calling application.

The Browser will attempt to reuse the same window each time the application launches the Browser with the same identifier.
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

Marti

  • Newbie
  • *
  • Posts: 24
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #4 on: February 03, 2016, 05:16:49 pm »
Kostya, thank you for your prompt reply. If I understand you correctly,  I have opened a tab by clicking on a URL in AquaMail and, when I click on another URL in AquaMail, it re-uses the same tab? If so, that makes no sense to me. I click on many URLs from email - I would never want them to overwrite an already open tab unless exactly the same - see discussion below. And in my case,  the tab that was overwritten was one I originally opened in the browser,  not from email.

If I understand your quote, I would expect AquaMail to go to an open tab if the identifier is exactly the same. That makes sense, e.g, I click on the same link to a book or news story or whatever. But if the identifier is not EXACTLY the same, I expect AquaMail to open in a new tab.

And even if I had originally opened a tab from AquaMail and then browsed to another site, that tab should not be reused by AquaMail because the identifier is no longer the same. As I mentioned in my original post, Gmail app does not behave this way.

Possibly it's a unique interaction between FireFox and AquaMail?

Would it help if I followed the instructions for creating a debug file and sent it to you? If the way AquaMail is working is the way you expect it to work, I will have to (ugh!) go back to Gmail app. I hope not.

Thanks for your help.

mikeone

  • Hero Member
  • *****
  • Posts: 2762
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #5 on: February 03, 2016, 07:33:28 pm »
Hi, did you tested the interaction between:

• AquaMail and Chrome browser
• Gmail app and Firefox
• Gmail app and Chrome

It would be great to get your feedback for these scenarios.

Thanks a lot.

Mikeone

Marti

  • Newbie
  • *
  • Posts: 24
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #6 on: February 03, 2016, 11:16:13 pm »
Good questions, Mikeone.

Gmail app to Firefox - works every time, no matter how many tabs are open or how they were opened.

Gmail app to Chrome - works every time, no matter how many tabs are open or how they were opened.

AquaMail app to Chrome - with one tab open, first url opened properly in new tab. Then clicked on another url in same email (shouldn't matter) and it overwrote previous tab.

Hope this helps!


mikeone

  • Hero Member
  • *****
  • Posts: 2762
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #7 on: February 03, 2016, 11:43:58 pm »
Good questions, Mikeone.

Gmail app to Firefox - works every time, no matter how many tabs are open or how they were opened.

Gmail app to Chrome - works every time, no matter how many tabs are open or how they were opened.

AquaMail app to Chrome - with one tab open, first url opened properly in new tab. Then clicked on another url in same email (shouldn't matter) and it overwrote previous tab.

Hope this helps!
Thanks.
So it looks like Gmail doesn't follow Google's own "Android convention"...

http://developer.android.com/intl/ru/reference/android/provider/Browser.html#EXTRA_APPLICATION_ID

Quote
The value is a unique identification string that will be used to identify the calling application.

The Browser will attempt to reuse the same window each time the application launches the Browser with the same identifier.


mikeone

  • Hero Member
  • *****
  • Posts: 2762
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #8 on: February 04, 2016, 12:41:31 am »
@Marti:
I just tested with Firefox:

AquaMail app to Firefox (version 39.0)- opens a new tab every time, no matter how many tabs are already open or how they were opened. Even tap on a link twice opens two separate tabs in Firefox 

AquaMail app to Firefox Beta (version 45.0b1)- opens a new tab first but overwrites an already open tab (previous opened by AquaMail!) everytime.

Therefore I guess, the behavior depends on a specific setting inside Firefox

Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #9 on: February 04, 2016, 12:59:47 am »
Found it.

In addition to EXTRA_APPLICATION_ID, K9 Mail and Gmail set another "extra" called EXTRA_CREATE_NEW_TAB.

https://github.com/k9mail/k-9/blob/master/k9mail/src/main/java/com/fsck/k9/view/K9WebViewClient.java#L76

This was added in Android 3.1, and so I missed it (my code goes back to 1.6 times).

http://developer.android.com/intl/ru/reference/android/provider/Browser.html#EXTRA_CREATE_NEW_TAB

I'm going to make add this too, so you'll always get a new tab with AquaMail -- just like with K9 Mail or Gmail.
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/

Marti

  • Newbie
  • *
  • Posts: 24
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #10 on: February 04, 2016, 05:22:32 pm »
Mikeone, I'm using Firefox 44 (not Beta) on Samsung S2 tablet with Android 5.1.1 and it didn't work. I just installed K's new version and - voila - works perfectly! Thanks so much, K, for sticking with this one!

mikeone

  • Hero Member
  • *****
  • Posts: 2762
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #11 on: February 04, 2016, 07:07:53 pm »
Mikeone, I'm using Firefox 44 (not Beta) on Samsung S2 tablet with Android 5.1.1 and it didn't work. I just installed K's new version and - voila - works perfectly! Thanks so much, K, for sticking with this one!
Marti:
Now you should try the newest development build 1.6.1.0-dev4.2 from the forum here:
http://www.aqua-mail.com/forum/index.php?topic=4399.0

Kostya has solved your issue with this version.
Tested: works fine for me (both of my Firefox versions)

Thanks to Kostya 👍

beaky

  • Full Member
  • ***
  • Posts: 169
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #12 on: February 10, 2016, 04:52:05 am »
I think I see this behaviour too when opening a link from Tapatalk. Not just from aqua mail.
I also find that the link opened does not seem to be in the browser history, which is a minor irritation. Typically links opened using links from other apps open in an existing tab within Chrome, and I have always thought it was an irritating Android quirk that it does not appear in the history.

Dave Beakhust, via Tapatalk


Kostya Vasilyev

  • Hero Member
  • *****
  • Posts: 12740
Re: Vsn 1.6.0.10 overwrites Firefox tab when click on url
« Reply #13 on: February 12, 2016, 08:26:24 pm »
At this time, the code in AquaMail for opening links matches exactly that in K9 Mail, stock Email and Gmail apps.
Creating debug logs for diagnostics: https://www.aqua-mail.com/troubleshooting/

The official FAQ: https://www.aqua-mail.com/faq/

Лог-файлы для диагностики: https://www.aqua-mail.com/ru/troubleshooting/

Вопросы и ответы: https://www.aqua-mail.com/ru/faq/