AquaMail Forum

English - Android => Development builds => Topic started by: Kostya Vasilyev on February 13, 2018, 08:12:30 pm

Title: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 13, 2018, 08:12:30 pm
https://www.aqua-mail.com/download/AquaMail-market-1.14.0-776-dev-4b9278b1e483.apk

https://www.aqua-mail.com/download/AquaMail-market-1.14.0-777-dev-76cf30f1baf9.apk

https://www.aqua-mail.com/download/AquaMail-market-1.14.0-778-dev-f71aaf2a8439.apk

https://www.aqua-mail.com/download/AquaMail-market-1.14.0-779-dev-382332ce4bf3.apk

https://www.aqua-mail.com/download/AquaMail-market-1.14.0-780-dev-90de0eb8e276.apk

---

More changes to new editor:

+ When expanding hidden "quoted" text - the cursor is now set to "just before" that.

Pressing "enter" at this point will insert a new line *above* the quoted (now expanded) text.

+ Do not add a new line when expanding anymore. Therefore, what you send is going to be consistent for "expand" vs. "do not expand".

+ Dark theme - kind of. Darker shade of white (light gray). Just did what we could.

+ Build 777: 1) another adjustment to cursor position after expanding "quoted" original message. 2) smaller "tap sensitive" area hopefully less prone to accidental taps.

+ Build 778: 1) fixed "original text not visible in sent messages" reported by @mikeone and @stevealb

+ Build 778: 2) when replying / forwarding, add a new line above "original" text in all cases (the "..." expanded or not), so it separates your new text from the quoted message

+ Build 779: fixed a data loss case when switching from the compose screen to a new message via notification.

+ Build 780: fixed a regression, Back -> prompted to save -> choose "discard" -> would still save the draft.

---

Дорабатываем новый редактор:

+ При раскрытии "цитируемого" сообщения - курсор перемещается "перед" раскрывшейся частью.

При добавлении новой строки в этот момент - она добавится *над* цитируемым текстом.

+ При раскрытии - теперь новая строка не добавляется "сама". Содержимое при отправке таким образом становится одинаковым, "раскрывали" цитату или не раскрывали.

+ Тёмная тема - типа того. Фон теперь не белый а светло-серый. Сделали что могли.

+ Сборка 777: 1) снова доработано положение курсора после "раскрытия" цитируемого сообщения 2) размер области "где нажать" стал меньше, надеемся что не так просто нажать случайно.

+ Сборка 778: 1) исправлено "пропадание" цитируемого текста при просмотре сообщений если "скрывать цитаты" выключено

+ Сборка 778: 2) при ответе / пересылке "над" цитируемым сообщением всегда добавляется пустая строка, чтобы отделить новый текст от цитируемого, неважно раскрывается блок "..." или нет.

+ Сборка 779: исправили потерю данных при переключении с экрана написания на входящее сообщение (через уведомление).

+ Сборка 780: исправили регрессию, Назад - окно предлагает сохранить - выбрать "не сохранять" - всё равно сохраняло.
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: heisert on February 13, 2018, 11:31:21 pm
Quote
+ Dark theme - kind of. Darker shade of white (light gray). Just did what we could.

Thanks for taking your time for us "Amoled black skin" lovers. :-)

But i cant see a different to the older Versions. It's me or could you maybe post a Screenshot of the new darker one?

Gesendet von meinem XT1635-02 mit Tapatalk
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: stevealb on February 14, 2018, 12:00:49 am
I notice that even when I expand the original email I'm replying to, the original text does not show up in the email that I send. It only shows the original header and my response above it.

I need the email responses to show the original email text below it.

Thanks
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 12:25:55 am
Quote
Thanks for taking your time for us "Amoled black skin" lovers. :-)

But i cant see a different to the older Versions. It's me or could you maybe post a Screenshot of the new darker one?

Sure. It's not "properly dark" - I just darkened the background, from pure white to a light gray.

Still should be "easier on the eyes" compared to "pure white".

Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 12:28:11 am
Quote
I notice that even when I expand the original email I'm replying to, the original text does not show up in the email that I send. It only shows the original header and my response above it.

I need the email responses to show the original email text below it.

The original header - meaning "who wrote what when"?

Is the original "body text" visible on the compose screen if you expand the "toggle"?

What if you don't expand - in this case we'll merge the original text into your message (unless you delete the "toggle" thing, the "...")?

I just tried two random messages (in addition to the testing we've done already) and wasn't able to reproduce.

Is it consistent for you? Or just some specific messages? Are you able to reproduce "at will"?

Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: mikeone on February 14, 2018, 12:32:31 am
I notice that even when I expand the original email I'm replying to, the original text does not show up in the email that I send. It only shows the original header and my response above it.

I need the email responses to show the original email text below it.

Thanks
Confirmed. It 'seems' to be a bug... sometimes:
Needs more investigation.
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 12:44:03 am
Re: Confirmed. It 'seems' to be a bug... sometimes

And a serious bug too - so what can we do to reproduce this?

You're not deleting the "..." block (which represents the original message) by accident, are you (and @stevealb too)?
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: mikeone on February 14, 2018, 01:19:29 am
Re: Confirmed. It 'seems' to be a bug... sometimes

And a serious bug too - so what can we do to reproduce this?

You're not deleting the "..." block (which represents the original message) by accident, are you (and @stevealb too)?
Hi Kostya,
I just send you an email with a sample message (.eml file) and two screenshots.
PS: the forwarded message was edited (tap on the "..." block -> to delete a couple of lines from the original / forwarded message) before sending.

Result:
It only shows the original header and my response above it (with AquaMail).
However, all is fine if I open the send message with Thunderbird.

Regards
Mikeone
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: stevealb on February 14, 2018, 01:20:39 am
Not deleting anything. But what I've now seen on a return email from the original sender is that the original email text seems to be there, though it's not there when I looked in my sent folder. Very strange.

Can we also get an option that has the original text already expanded without having to press the 3 dots?
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: mikeone on February 14, 2018, 01:29:51 am
Not deleting anything. But what I've now seen on a return email from the original sender is that the original email text seems to be there, though it's not there when I looked in my sent folder. Very strange.
Yes, you can see the original message text in your sent folder, e.g. with Thunderbird or on your web mail server, but - unfortunately - not in AquaMail.

Can we also get an option that has the original text already expanded without having to press the 3 dots?
I second your suggestion :)
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 03:17:56 pm
@mike - I'm having trouble reproducing even with the sample messages you sent me (thanks again).

In fact I uploaded the "sent" .eml to my account and when downloaded into Aqua - I get the "expand quoted text" button and if I tap that, the original text does show.

I also tried replying to the "original" .eml - deleting some text - adding and removing some text (seems that you removed some dummy "xxx" and "yyy" and  added "versuch") - and the sent message is fine in Aqua again ("expand quoted text" button - tap that - original text does show).

So I'm pretty lost right now. And then this is a very serious issue.

---

What is you phone's Android version please?

If it's 7.0 or newer - what is the version of Google Chrome?

If it's 6.0 or below - what is the version of Android System WebView?

To check - phone Settings -> Apps -> three dots -> Show system apps -> find and tap "into" Chrome or WebView.

---

@stevealb - ok you're not deleting the whole "original" block (the "{...}"), did you make any edits to the original text? Deleting / adding anything there?
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: stevealb on February 14, 2018, 03:49:54 pm
I didn't touch the original text at all. I just experimented with expanding the original text or not. Either way, the original text does not show up in the email from the sent folder.
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 03:52:11 pm
@steveab


Quote
I didn't touch the original text at all. I just experimented with expanding the original text or not. Either way, the original text does not show up in the email from the sent folder.

Ok got it.

What about Android / WebView / Chrome versions?

Would it be possible to get message samples from you as .eml attachments?

Both the original message (the one you replied to) and what actually got sent - would be great. My personal email is kmansoft / gmail.
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: mikeone on February 14, 2018, 04:13:55 pm
What is you phone's Android version please?
Android 8.0.0
Sony Xperia XZ

If it's 7.0 or newer - what is the version of Google Chrome?
Version 64.0.3282.137


PS:
I will observe this issue further...
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 05:19:02 pm
@mikeone, @stevealb

Aqua Mail settings -> message view -> hide quoted text

Turned OFF for you guys?

Defaults to ON - can you try ON please?

When OFF - the quoted snippets are supposed to "just show" always without the "show quoted text" buttons / links.

But in current build when "hide quoted text" is OFF - the quoted snippets do not show at all.

That's the bug.

Probably has nothing to do with the new editor itself.

Since I'm now able to reproduce - will fix later today and post a new build.
Title: Re: Version 1.14.0-778-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 07:58:10 pm
@mikeone, @stevealb

Fixed in build 778 above. Thanks for your help.
Title: Re: Version 1.14.0-778-dev - "work in progress", not in Google Play
Post by: mikeone on February 14, 2018, 09:33:35 pm
@mikeone, @stevealb

Fixed in build 778 above. Thanks for your help.
Kostya, you have fixed this weird bug.
Thanks!
Mike
Title: Re: Version 1.14.0-778-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 14, 2018, 10:57:16 pm
New build 779

+ Build 779: fixed a data loss case when switching from the compose screen to a new message via notification.

+ Сборка 779: исправили потерю данных при переключении с экрана написания на входящее сообщение (через уведомление).
Title: Re: Version 1.14.0-777-dev - "work in progress", not in Google Play
Post by: stevealb on February 15, 2018, 12:40:28 am
@mikeone, @stevealb

Aqua Mail settings -> message view -> hide quoted text

Turned OFF for you guys?

Defaults to ON - can you try ON please?

When OFF - the quoted snippets are supposed to "just show" always without the "show quoted text" buttons / links.

But in current build when "hide quoted text" is OFF - the quoted snippets do not show at all.

That's the bug.

Probably has nothing to do with the new editor itself.

Since I'm now able to reproduce - will fix later today and post a new build.

"Show Quoted Text" whether on or off always results in the three dots showing which have to be pressed to show the hidden original email message.

Also, when you press the 3 dots to show the original text, the cursor lands in the blank line just above the hidden text but below the signature. The cursor needs to land at the top of the message above the signature.
Title: Re: Version 1.14.0-779-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 15, 2018, 12:48:16 am
Quote
"Show Quoted Text" whether on or off always results in the three dots showing which have to be pressed to show the hidden original email message.

I was talking about message view, not compose screen, that's what the setting applies to.

Your sent messages should now be showing all quoted / original text (now = build 778 above or newer).

Quote
Also, when you press the 3 dots to show the original text, the cursor lands in the blank line just above the hidden text but below the signature. The cursor needs to land at the top of the message above the signature.

There currently is a disagreement between several highly esteemed users of this fine app about this (where the cursor should go and whether it should go anywhere at all).

I believe the way it works right now (again, 778 and newer) is the best middle ground which serves two most common scenarios.

1 - if you just need to look something up, keeping the cursor essentially at the old position, where the "(...)" was, avoids excessive scrolling which might have moved the original now expanded text out of sight (esp. if your signature is "tall");

2 - if your intent with expanding the original message is to add "inline style" reply snippets, you'll have to re-position the cursor anyway so your reply snippets can go into the right places in the original message.
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Justin on February 16, 2018, 09:10:57 pm
Quote
There currently is a disagreement between several highly esteemed users of this fine app about this (where the cursor should go and whether it should go anywhere at all).

Yes. I don't understand, why it is necessary to insert a new blank line 1, when expand the quoted text.

I have to delete this line every time.
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: diqua01 on February 17, 2018, 05:09:31 pm
FYI
On 16.2.2018 I had a loss of all Configs after restart of mobile (I do a restart very seldomly): Aquamail started with the first installation screen asking for Mailaccounts (all were gone).
I loaded a backup from October 2017 and all was fine again.
I am running Aquanail with 3 imap mail acounts at 1und.de, 1 imap at gmx, 1 gmail, one office 365 on a Nomu S10 with Android 6.0.1, Aquamail 1.14.0-780-dev
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: EKinMN on February 18, 2018, 09:15:58 pm
Thanks for the great info!
I there a way I can turn off the new editor completely?  I am not a fan of the grey screen (prefer black), and I like to see the full message I am replying to.  I've read the posts above, and after doing so, would prefer to just turn it off is possible (i.e. I liked the last version best).
Thanks!  Best app and dev team ever!
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 18, 2018, 09:51:17 pm
Quote
I there a way I can turn off the new editor completely?  I am not a fan of the grey screen (prefer black), and I like to see the full message I am replying to.  I've read the posts above, and after doing so, would prefer to just turn it off is possible (i.e. I liked the last version best).

Sure - app settings -> composing and sending.
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: EKinMN on February 19, 2018, 06:58:59 am
EXCELLENT!  That worked.  And, now I know I am free to go back and "play" with the editor when I want, and when I need the added functionality.  Truth be told, as I've been playing more with it, especially on my tablet, I like it more and more.

Thanks for giving options.  Such a great app, with great service!
EKinMN
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Justin on February 19, 2018, 09:46:06 am
@EKinMN Yes, this is my workaround, too:

Leaving the new editor disabled by default. If someday a bullet list is needed, I will enable it temporarily.
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: fjelsten on February 19, 2018, 04:48:14 pm
Hello

I am so happy for the MFA because my org just implemented this and I did not want to leave my beloved Aquamail for pested Outlook.

It seems to be working, but I cannot be sure because:
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 19, 2018, 10:28:05 pm
@fjelsten

Well yes you should be able to upgrade the account from "password based" to "OAUTH2" (MFA in particular) by long pressing on it on the app's main screen -> account setup -> and there should be a green panel / prompt to "enable OAUTH2".

If you tap that, the app will take you to the Microsoft login page where you'll need to log in using your corporate address (and confirming the SMS code if necessary, that's MFA).

After that the account setup process should continue and should work.

As for "user / domain" or "user \ domain" - that doesn't apply to accounts using OAUTH2, and we obtain the correct "form" of your email address from Office 365 automatically.

Can you please tell me at what point (in the above "what should happen") do things go wrong?

Are you getting a login error after all the above?

Can you try adding the account as brand new - just to see if you're able to complete the process, except you can just *not* Save at the end, but will it get to that point at all (the point of "account setup all done, just waiting for user to tap Save")?
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: fjelsten on February 19, 2018, 10:38:36 pm
Hi

I tried creating a fresh account. No problem there.

The problem is that it - at some stage (even if I remove the <domain> from the pre filled in <domain>\<email> in all the Microsoft form elements during MFA) it seems to fetch the old <domain>\<email> at the very last step where I click the blue button "Accept" (app access to mailbox, etc). Throughout the process, the content in the white (web elements) will say <email> but the heading says "Please log into <domain>\<email>.

After clicking Accept I just get a prompt saying "please login to <email> and not <domain>\<email> - and then I can start over - so something is reading this.

I have done a screen cast I can send via private mail.
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 19, 2018, 10:51:08 pm
Re:

Quote
After clicking Accept I just get a prompt saying "please login to <email> and not <domain>\<email> - and then I can start over - so something is reading this.

Starting to get some ideas.

Yes please send the screencast to support / at / aqua-mail / dot com.

It would also be great to get a debug log with "raw session data" of the "upgrade process" which fails - please see the link in my signature below and look under "Creating a log if something doesn’t work right".

Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: fjelsten on February 19, 2018, 11:06:07 pm
Mail sent, subject "MFA and domain not deleted"
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 19, 2018, 11:17:15 pm
Re: Mail sent, subject "MFA and domain not deleted"

Hmm, the log doesn't have the information I was expecting.

Did you enable "raw session data" in debug log settings?

Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: fjelsten on February 19, 2018, 11:24:44 pm
Yes.

Maybe the Chrome/browser element (I'm guessing) takes care of the communication which is why there is no log of this?
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 20, 2018, 12:07:18 am
Re: Maybe the Chrome/browser element (I'm guessing) takes care of the communication which is why there is no log of this?

Um, actually, no - there was supposed to be a bunch of stuff in the log that wasn't.

Maybe you can try making a new log please?
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: fjelsten on February 20, 2018, 12:34:22 am
Done it again and sent.
Title: Re: Version 1.14.0-780-dev - "work in progress", not in Google Play
Post by: Kostya Vasilyev on February 20, 2018, 12:38:30 am
Re: Done it again and sent.

Much better!
Title: Re: Version 1.14.0-780-dev - &quot;work in progress&quot;, not in Google Play
Post by: moon233 on March 08, 2018, 10:04:57 am
:)

Sent from my Google Nexus 6 using Tapatalk