AquaMail Forum

English - Android => Development builds => Topic started by: Kostya Vasilyev on November 01, 2015, 11:07:21 pm

Title: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 01, 2015, 11:07:21 pm
http://www.aqua-mail.com/download/AquaMail-market-1.6.0-14-dev1.apk

---

*** Conversation view:

- Overall approach:

There are different ways to present threads (conversations) in the UI.

I deliberately did not do it "like in Gmail" -- had comments from users who don't like it, and then what's the point.

I did not do it "like in K9 Mail or iPhone Mail" -- where you first "tap into" a thread and then tap again to open a message.

And then there is what Samsung does in their email app -- in my opinion, worst I've seen.

Turned out, the approach I came up with is used in Sony's mail app (I have an Xperia Z2).

- Swiping between messages will only go though at most 3 messages per thread (settings -> message view -> navigation).

- Messages are linked by message headers (Message-ID, In-Reply-To, References) *only*.

No linking by subject or sender alone when those header are absent. This is intentional:

I really hate it how some mail apps combine distinct unrelated messages like forum notifications ("A new reply has been posted") or messages with subjects like "Question" or "Order" (coming from different people, even).

- Linking across folders (incoming vs. sent) is not enabled by default, please see app settings -> message list if you need it.

- Needs more work on message list jumping up or down sometimes, needs animations too, and "customize color" settings.

- Widgets have their own "threaded or not" setting, app settings -> widgets.

- Not sure if I got per-message contact images and/or recipient name right for the threaded view, can be fine-tuned based on feedback.

- Probably needs to not expand really large threads (say past a dozen or two messages) upon single click, may be better to only show say a dozen, then have a place to tap "show xxx more messages from this conversation".

*** Added "one month" time period in Smart Folder

*** Added "mark read upon" - "when closing a message" (settings -> message view) for those who like to use "sort by unread first"

---

*** Группировка сообщений по переписке:

- Общий подход:

Есть разные способы показывать цепочки в интерфейсе.

Я специально не стал делать "как в Gmail" -- мне писали что "не нравится", и потом это бессмысленно (есть же Gmail, ну и).

Не стал делать "как в K9 Mail и iPhone Mail" -- в их подходе надо сначала открыть цепочку, затем нажать ещё раз чтобы открыть  сообщение.

И не стал делать как в почте Самсунга, мне кажется там хуже всего.

В итоге оказалось, что тот же подход используется в почте Sony (у меня есть Xperia Z2).

- Пролистывание между сообщениями "смотрит" только на 3 самых новых сообщения из каждой цепочки (настройки - отображение сообщений - навигация).

- Сообщения связываются *только* по заголовкам (Message-ID, In-Reply-To, References).

Связки только по теме или отправителю в отсутствие данных заголовков нету. Это намеренно:

Мне совершенно не нравится как некоторые почтовые программы могут объединить сообщения не являющиеся цепочкой, например уведомления с форумов ("В теме размещен новый ответ") или такие темы как "Вопрос" или "Заказ" (даже от разных людей).

- Связывание между папками (входящие - отправленные) отключено по умолчанию, см. настройки - список сообщений если Вам это нужно.

- Нужно ещё поработать над списком сообщений, сейчас он может "прыгать" при раскрытии цепочек, наверное нужна анимация, настройки цветов.

- В виджетах "список сообщений" цепочки включаются отдельно, настройки - виджеты.

- Не уверен что всё сделал правильно с картинками и именами контактов при отображении цепочек, доработаю если предложат идеи.

- Вероятно очень большие цепочки лучше не раскрывать сразу польностью, а скажем 10 писем а остальные "нажмите здесь чтобы отобразить ещё ... столько-то".

*** Добавил "один месяц" в настройках умной папки.

*** Добавил "помечать прочитанным" - "при закрытии" (настройки - отображение сообщений) для фанатов сортировки "непрочтенные сначала".

Уффф. Мы писали, мы писали, наши пальчики устали.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 02, 2015, 09:44:50 am
Kostya,

Congrats!
Even though message threading is not a necessity for me, I've been curious to see "what's cooking". I don't have long threads at the moment (only 2-3 messages), so, I cannot evaluate this to the full extent, but it seems to work.
I think some time is needed to get a real feel of it.

In the mean time, I wanted to share one thought.
Once I installed the new apk and opened the app, it offered me to index the messages. I agreed, and then Aquamail went into thinking... I didn't time it, but I think it took at least 5 minutes... The phone (XT-907) was only semi-responsive during that time. (At the moment, I have 4 IMAP accounts in Aquamail, of which only one has "high traffic". The rest receive 1-5 messages per day.)
Aquamail indicated that there were close to 1400 messages that it indexed.
Fortunately, I was not in a big rush... If I were, I would've been mad.

So, my suggestion: the same way as some programs do, add a warning to that confirmation (index?) that it may take several minutes to complete. This way you may save some unhappy minutes to some Aquamail users.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: julio66 on November 02, 2015, 04:40:15 pm
It is amazing Kostya.
I get your points of why you did it the way you did, but for my part love the option to be able to tread the messages after contacts not only subject....In my opinion it is nicer to get all the mails from one user/contact treaded, independent of the subject. Ex; If I have 20 mails from you, not all with the same subject, it would be cleaner and more easy to have them all in ONE CONVERSATION (tread).
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: nadir husain on November 02, 2015, 06:04:03 pm
ok kostya- this is a work of art.  i am not a great fan of " conversation view"  having only seen gmail and k9 but i think i could very easily get used to this.  you really do have that midas touch.  kudos  :)
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: beerlao on November 02, 2015, 10:07:57 pm
Congratulations, that is how threading should be done. Don't group messages by subject, but take care of References Header :-) Very well done and it works great!  Thank you!
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 02, 2015, 10:20:19 pm
Re:

Quote
The phone (XT-907) was only semi-responsive during that time. (At the moment, I have 4 IMAP accounts in Aquamail, of which only one has "high traffic". The rest receive 1-5 messages per day.)
Aquamail indicated that there were close to 1400 messages that it indexed

An pretty old phone, but that's fine. I'll write it down and maybe will make it possible to cancel the indexing (if I can).

Re: "group by sender not by conversation" -- ummmm... not sure about this...

And to everyone else's very positive comments -- thank you, thank you, thank you!

There is still work to do, now I'm twice as excited about it.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: mikeone on November 03, 2015, 12:14:30 am
Quote
So, my suggestion: the same way as some programs do, add a warning to that confirmation (index?) that it may take several minutes to complete. This way you may save some unhappy minutes to some Aquamail users.
Kostya:
I agree with StR"s suggestion to add at least a "warning" that the following indexing will take "some" time to complete (up to several minutes).

In addition:
Conversation view is working fine. Well done, Kostya!
Kind regards
Mikeone
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 12:29:01 am
Re: indexing

It really depends.

On a Sony Z2 (2013 device, IIRC) it takes 12 seconds for 3500 messages.

On a Samsung S4 Mini (2012, low end device), it takes 26 seconds for 3500 messages.

So I added a cancel button -- if the user sees it actually is taking too long, he/she can just cancel and do it later.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: mikeone on November 03, 2015, 12:41:32 am
On my phone (Sony Z3) the app had to indexing round about 9000 messages. It takes more than 30 sec. to count up. Then the progress bar stucks at 99% for a while... I think also more than 30 sec. until indexing was completed.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 12:45:00 am
12 sec for 3500 for me -> yes, makes sense it would take longer than 30 seconds for you.

And yes, there is a mass update at the end of the process.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: mikeone on November 03, 2015, 12:52:30 am
In total: 8520 messages

2nd turn (New version wizard - debug):
after 15 sec: 41%, 30 sec: 82%, 45 sec: 100%
...and NO mass update at the end now (in contrast to the 1. pass)
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 12:53:34 am
Yes, the mass update is done incrementally -- so if already done once, it updates just a few messages or none...
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: pyler on November 03, 2015, 01:03:05 am
Indexing process was interesting btw :D firstly it was at 0% for maybe 15 seconds but I kept it as is. Then progress bar started doing something after 10 seconds everything was ok.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 01:04:20 am
15 seconds ???

How many message was it showing - approximately, if you remember?

And what's the phone?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: mikeone on November 03, 2015, 01:08:27 am
Kostya:
Thanks for your explanations.

Nevertheless I think it would be helpful if the user will get a note beforehand that the following indexing will take some time. This could avoid some uncertainty for users.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 01:10:01 am
OK. I'll try to think of a way to word it so it's not too scary (preventing it from getting enabled).
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: mikeone on November 03, 2015, 01:14:51 am
OK. I'll try to think of a way to word it so it's not too scary (preventing it from getting enabled).
Something like "The following indexing will take some time (usually not more than a minute, but it depends on the amount of messages ... ). Please be patient."
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: paras.desai on November 03, 2015, 05:48:01 am
ok kostya- this is a work of art.  i am not a great fan of " conversation view"  having only seen gmail and k9 but i think i could very easily get used to this.  you really do have that midas touch.  kudos  :)

+1

Though not fond of conversaion view, I am totally convinced by the masterpiece realized by Kostya. Thank you, developer :)
Threaded view works perfectly,  my 2000 messages were indexed in no time,  around 5 to 10 seconds.  Individual contacts photo within threaded message works fine.  Yes shading or coloring and some animation will add spice to the already well cooked stuff.  Congrats kostya  and Thanks. 
ok kostya- this is a work of art.  i am not a great fan of " conversation view"  having only seen gmail and k9 but i think i could very easily get used to this.  you really do have that midas touch.  kudos  :)


Sent from my HTC One_E8 dual sim using Tapatalk

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 03, 2015, 03:47:31 pm
Great job Kostya!
I was looking forward to this feature as a reason to purchase pro. I purchased pro last month anyway (without threading) as I was impressed by your dedication to the app. You've proven yourself again ☺

Some feedback on conversation view:
1. I'm a fan of Google's method, but yours seems very good too. Might just be a matter of getting used to.
2. Can you include user options for how grouped messages are shown? I'd like the thin line (on left side) to be slightly more obvious /thicker. That's just me, so options might be better than outright change.
3. Is it possible to have different message list settings (number of rows shown, etc.) for msgs in a conversation group? I'd like to compact a lot of that view given lots of that metadata is constant (inherently due to it being part of a conversation). This could save space and user parsing while reading the grouped messages ☺.
4. When clicking on /viewing a message that's part of a conversation, can you please provide a reference in the header space (perhaps on top right) to show which message it is within the group. (Eg:  5 of 7). This makes it easier to swipe left/right, without going beyond the conversation (into other messages).

If you'd like pictures please just ask.

Thanks.
Ps. I use dark theme.

Sent from my SM-G920F using Tapatalk
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: pyler on November 03, 2015, 07:07:54 pm
15 seconds ???

How many message was it showing - approximately, if you remember?

And what's the phone?

Samsung S2 Plus.. I think around 1000 messages...
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 09:05:09 pm
@Iceman_jkh

Re: Gmail vs. how I did it

Well, I don't see much sense in copying Gmail's UI patterns verbatim -- if someone really prefer Gmail app, it's there

Re: Is it possible to have different message list settings (number of rows shown, etc.) for msgs in a conversation group

What aspects / attributes?

I don't imagine that using a different setting for something like "unread color" would be useful -- so is it the number of preview lines, mostly? The idea being to use a smaller number of lines in a thread's "children"?

In terms of other things -- it is possible to swipe "out of" a thread, is the idea to avoid it?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 09:06:50 pm
Quote
The phone (XT-907) was only semi-responsive during that time. (At the moment, I have 4 IMAP accounts in Aquamail, of which only one has "high traffic". The rest receive 1-5 messages per day.)
Aquamail indicated that there were close to 1400 messages that it indexed

I am not sure if it is useful information or not, - in my case, the progress bar was incrementing by the same number of messages, 250, IIRC. Each such step was taking about a minute.

Just in case, - I'd like to clarify. I am not sure if all other users are reporting the number of the messages loaded in Aquamail, or the total number of messages reported by Aquamail for the particular account/folder.
In my case, the progress bar was showing close to 1400 messages total (1374?). That's most likely the number of messages that were loaded in Aquamail.
The total number of messages, just in the Inbox of the most active account is about 6300.

Just a thought: is there a simple way to remove indexing and then re-index the images, - just for the purpose of reproducing it (in case it was an odd, one-off case caused by some weird state of my phone), - without deleting the account and multiple reinstallation of Aquamail?

I guess I can set up a new account in Aquamail, load messages, - but how can I make sure that they are not indexed during the initial loading? Can I do that without going back to the older version of AM first?
Will going to the older version of AM corrupt the present, updated AM database?

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 09:12:00 pm
Re: Just a thought: is there a simple way to remove indexing and then re-index the images, - just for the purpose of reproducing it (in case it was an odd, one-off case caused by some weird state of my phone), - without deleting the account and multiple reinstallation of Aquamail?

Yes, app settings -> message list -> turn conversation off and on.

This will fully re-index, in the next -dev build you'll see it working incrementally.

Re: the progress bar was incrementing by the same number of messages, 250

Yes, multiple messages per database transaction.

Re: Each such step was taking about a minute

A minute per 250 messages is really, really long.

Was "a minute" how it "felt", or did you actually time it (wall clock, watch, the status bar time indicator)?

Re: how can I make sure that they are not indexed during the initial loading

Any messages received when "conversation view" is enabled will be indexed right then. And that should not take a minute :)
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 09:17:50 pm
I like the way the threading is implemented, great job, Kostya!
Even though I was not "in need" of it, but I tried, and I am going to keep it.

A couple of thoughts about the new "feel and look":
I am currently using the dark theme (switched just a few weeks ago) (old style, on Android 4.1.2).
It is hard to distinguish a collapsed thread from a regular message. The only difference I see is the number of messages indicated on the right hand side. But when I am looking at the messages that arrived, I am looking primarily at the top left corner of the message "rectangle", where the sender and Subject information is, - to decide if/what I need to read immediately. If I don't realize it is a thread with the messages hidden inside it, I might miss the messages on that thread, thinking it was only one message there.
So, I was wondering if you can make some differentiation in the looks of the thread (in the message view) form a single message. -- I don't know what that should be: shading, a line, - but something easily visible upon a quick, unfocused look.

And I second this request:
Quote
I'd like the thin line (on left side) to be slightly more obvious /thicker.

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 09:26:31 pm
Re: If I don't realize it is a thread with the messages hidden inside it, I might miss the messages on that thread, thinking it was only one message there

If this thread has just received messages, than those should be unread, and the thread itself should be showing at unread -- brighter text, different background...

Or should I make the "thread count indicator" brighter (in the dark theme, I guess it's fine in the light themes).

Re: thicker line on the side

Sure, let's try it and see how it works out.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 09:27:52 pm
Re: Just a thought: is there a simple way to remove indexing and then re-index the images, - just for the purpose of reproducing it (in case it was an odd, one-off case caused by some weird state of my phone), - without deleting the account and multiple reinstallation of Aquamail?

Yes, app settings -> message list -> turn conversation off and on.

This will fully re-index, in the next -dev build you'll see it working incrementally.
Ok, thanks! I might try to do that if I get some 20 minutes for testing..

But wait... so if I disable "conversation", AM looses indexing?
My assumption was that it wouldn't... I haven't thought much about it, but I had assumed people might go occasionally between two types of viewing... But maybe you are right... Having seen the implementation, I am no longer sure I'd need to switch between the two back and force...

Quote
Was "a minute" how it "felt", or did you actually time it (wall clock, watch, the status bar time indicator)?
As I've written in the original message, - I didn't time it. It was how I felt it -- for both the overall and per step timing. But I have a 1-minute timeout set on my phone, so, I was concerned what would happen to indexing if the phone would turn the screen off. I don't remember for sure, but I think it actually did, turn off the screen once during that process.

Quote
Re: how can I make sure that they are not indexed during the initial loading

Any messages received when "conversation view" is enabled will be indexed right then. And that should not take a minute :)
I guessed that part, - but I was trying to verify the opposite to that:
if the "conversation view" is turned off, would the app still index the messages received for the purpose of the "conversation view"?
Based on the first quotation at the top of this message, I suspect the answer is "no". Is this correct?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 09:32:08 pm
Re: if I disable "conversation", AM looses indexing

No, does not lose, but does not maintain (update) either.

The next dev build will have incremental indexing specifically for when conversation view is turned off for some duration of time and then turned on.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 09:41:39 pm
Re: If I don't realize it is a thread with the messages hidden inside it, I might miss the messages on that thread, thinking it was only one message there

If this thread has just received messages, than those should be unread, and the thread itself should be showing at unread -- brighter text, different background...

I am talking about the following situation:
There are several, say 3, messages in the thread, all new and unread.
It is only the latest message's information that is seen. If I don't care for that sender at the moment, or if the preview shown has already given me all information I needed from it (e.g. it is a 1-word reply), I wouldn't realize that there are 2 more messages from somebody else.
This actually has happened to me today.

Quote
Or should I make the "thread count indicator" brighter (in the dark theme, I guess it's fine in the light themes).
That might be useful.
But even with that, that indicator is on the far right, where usually only unessential (less-essential) information is located: time, message size... That's not where I am looking while quickly checking for new messages.

I'd say that one of the following might work better:
1. some type of different background/fill pattern (shading?)
2. horizontal line along the top of the thread rectangle
3. line on the left (similar to that in the expanded view)
4. slight ofset of the sender line (I am not sure if that's a good idea)

And just in case, - I am not using the Gmail-like "chips" (is that what those are called?)

Quote
Re: thicker line on the side

Sure, let's try it and see how it works out.
Great!
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 09:43:50 pm
Re: if I disable "conversation", AM looses indexing

No, does not lose, but does not maintain (update) either.

Ok, then my thought about doing a test of complete re-indexing -- that I asked you about -- would not work the way you suggested (turning "conversation view" off, then on again). It wouldn't do the complete re-indexing.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 09:53:04 pm
Re: would not work the way you suggested (turning "conversation view" off, then on again).

It would.

Re: It wouldn't do the complete re-indexing

The version posted here so far will do complete re-indexing.

The next version, not posted, not existing yet, will do incremental.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 10:09:12 pm
Aah... I see.. Sorry, I misread your prior response.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 03, 2015, 10:16:21 pm
I just did the re-indexing test.
It was happening much-much faster this time.
Still, it took longer considerably longer then what has been reported by others so far.
This time I timed it: 75 seconds for 1394 messages. (XT-907, Android 4.1.2.)
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 10:19:54 pm
Re: XT-907

That's ~ 50 ms per message.

I have an HTC One S here, also a pretty old model, with 4.1 -- and there it takes ~10 ms per message.

Would you like to do another full reindex with the debug log enabled?

One other thing -- if you do Menu -> About, how large is the Messages.sqldb database?

On the HTC above, it's ~5.5 megabytes, I don't receive large messages often.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 03, 2015, 11:42:43 pm


@Iceman_jkh

Re: Gmail vs. how I did it

Well, I don't see much sense in copying Gmail's UI patterns verbatim -- if someone really prefer Gmail app, it's there

Re: Is it possible to have different message list settings (number of rows shown, etc.) for msgs in a conversation group

What aspects / attributes?

I don't imagine that using a different setting for something like "unread color" would be useful -- so is it the number of preview lines, mostly? The idea being to use a smaller number of lines in a thread's "children"?

Yes, exactly. Reducing the duplication of metadata too (sender, account), so that more actual "useful" data is shown when a conversation group is being shown.

Quote
In terms of other things -- it is possible to swipe "out of" a thread, is the idea to avoid it?

It's to inform the reader where they are in the thread, and prevent swiping out accidentally. I wouldn't want to block the reader from swiping "out", but I think it's helpful to know when the edges of a thread (start /end) has been reached.


Sent from my SM-G920F using Tapatalk

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 03, 2015, 11:48:07 pm
@Iceman_jkh: thanks.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 04, 2015, 12:25:41 am
Re: About, how large is the Messages.sqldb database?

It says:
19.11MB + 512KB

I'll see if I can do the debug log later..
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 04, 2015, 12:49:56 am


Re: Is it possible to have different message list settings (number of rows shown, etc.) for msgs in a conversation group

What aspects / attributes?

I don't imagine that using a different setting for something like "unread color" would be useful -- so is it the number of preview lines, mostly? The idea being to use a smaller number of lines in a thread's "children"?

Yes, exactly. Reducing the duplication of metadata too (sender, account), so that more actual "useful" data is shown when a conversation group is being shown.
There could be different senders in one thread/conversation. There could be different subject lines...
So, one has to be careful with what metadata can be omitted (and how).

(I can even imagine (although that might be a rear case) a conversation spanning across more than one account of the same user (e.g. when a person includes a personal and business account of the recipient. But I am not worried about that, as I am not using Smart Folder. Those who do, - might be concerned.)

Quote
Quote
In terms of other things -- it is possible to swipe "out of" a thread, is the idea to avoid it?

It's to inform the reader where they are in the thread, and prevent swiping out accidentally. I wouldn't want to block the reader from swiping "out", but I think it's helpful to know when the edges of a thread (start /end) has been reached.


I agree, but have no clue how that can be done elegantly...
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: jimfbk on November 04, 2015, 01:50:56 am
Favor - since I'm not seeing Conversation view on my unrooted Verizon Galaxy Note 5, could someone please post a screenshot of what it looks like?

Yes, I turned on Conversation view (and off, and on). 

I'm using 3 gmail accounts and one pop3 account, but I don't see the Conversation view (for the gmail accounts), and I'm curious (but not yellow).

Thanks,

jim
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: paras.desai on November 04, 2015, 04:38:32 am
Favor - since I'm not seeing Conversation view on my unrooted Verizon Galaxy Note 5, could someone please post a screenshot of what it looks like?

Yes, I turned on Conversation view (and off, and on). 

I'm using 3 gmail accounts and one pop3 account, but I don't see the Conversation view (for the gmail accounts), and I'm curious (but not yellow).

Thanks,

jim


Sent from my HTC One_E8 dual sim using Tapatalk

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: jimfbk on November 04, 2015, 07:13:13 am
Favor - since I'm not seeing Conversation view on my unrooted Verizon Galaxy Note 5, could someone please post a screenshot of what it looks like?

Yes, I turned on Conversation view (and off, and on). 

I'm using 3 gmail accounts and one pop3 account, but I don't see the Conversation view (for the gmail accounts), and I'm curious (but not yellow).

Thanks,

jim


Sent from my HTC One_E8 dual sim using Tapatalk

Thanks very much!  I'm not seeing anything like that.... time for a trip through the settings :)
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 04, 2015, 08:22:41 am
Quote
I'd say that one of the following might work better:
1. some type of different background/fill pattern (shading?)
2. horizontal line along the top of the thread rectangle
3. line on the left (similar to that in the expanded view)
4. slight ofset of the sender line (I am not sure if that's a good idea)

The current UI for Material design (light) is excellent. The number of conversation messages in white on dark blue backgroud is enough to show that it's a conversation. No need to something else (certainly not indent or slight offset), and please Kostya, do not add horizontal lines, vertical lines or whatever because you'll break the general harmony of the UI. I am speaking about light Material design only.

I understand that the material design theme might provide a higher contrast for the indicator of the number of the conversation messages (that's what Kostya suggested to boost in the old dark theme).
But it doesn't change the fact that that indicator is not in the "primary" view area as I explained above.

However, after seeing the snapshots posted by paras.desai, I see that what plays a bigger role in that case is those "chips", as the collapsed threads are missing the letter inside the "chip", and that is a distinctive feature. When the chips are disabled, there is nothing in the primary field of view (left portion of the screen) that can help to differentiate quickly.



Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: mikeone on November 04, 2015, 09:11:43 am
I agree with the thoughts of StR to get a more visible "indicator" for messages containing a conversation.

Message list
My favorite is #3 - a vertical (blue) line on the left side of these messages. Slightly wider than currently (when the conversation is expanded).

Message view
Furthermore I agree with Iceman"s request to get a "conversation indicator" in the message view.

A counter in (or right below) the header to see "where you are" within the conversation could be a very good solution:
[1] of [5], [2] of [5],..., [5] of [5]

Update:
Kostya, Thanks for implementing these new "Message counters" in message view.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 04, 2015, 02:57:22 pm
I have a discrepancy (not quite a bug) to report.
Basically, when using convo mode, I can't find a particular email that was sent (to me) on a certain date. I can't find it's subject anywhere in the convo list nor under the exact (or even approx) date group.
Only when I turn off convo mode or do a search for a word in the subject line does the email appear.

I don't really know how to help you debug this issue. Happy to explain further though :)

Some more info:
I sent the original email out to person A on 9 Sep 15 (from my PC gmail account via chrome). Subject line = subject 1
Person A replied (via different subject line entirely, but quoting my text) on 2 Oct 15 (received on all my email devices/PC gmail account via chrome). Subject line = Subject Two
I replied (without modifying subject) a few hours later (still the same day). Subject line = Subject Two

In convo mode, I can't find that subject line in my inbox even searching back past Sep 15.
In normal mode, I can find it at the correct date(s).
In convo mode I can find it using specific search terms.

Did gmail do 'something' to the email perhaps?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 04, 2015, 05:38:30 pm
@Iceman_jkh

Hmm...

If you do a search, then the results are not threaded (intentional), so I guess when you wrote "I can't find a particular email that was sent (to me) on a certain date" --

-- you meant "I don't see a particular message when scrolling through and looking for it, scanning what's on the screen"?

If so, well, it might happen that the message is "inside" a thread and you're not seeing it?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: jimfbk on November 04, 2015, 06:01:05 pm
Thanks again to paras.desai for the screen shots.

I now see what's going on on my phone.  I'm a zero inboxer - I read a message, then archive it.  Apparently, convo mode only works if all the emails are in the inbox (unless I have sync folders set incorrectly).

I did create a thread in the inbox - and I have to say that, as usual, Kostya's implementation is spectacular - it works so well and is so clear.  I wish GMail's threading worked so well!

P.S.  Yes, I did have syncing set incorrectly - convo mode now works (perfectly, I might add)... Yippee!
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 04, 2015, 06:17:19 pm
Re: Kostya's implementation is spectacular - it works so well and is so clear.  I wish GMail's threading worked so well

Thank you!

Nice to know that my bet on *not* "just doing it like in all other mail apps" is paying off.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 04, 2015, 06:33:40 pm
@Iceman_jkh

Since you mention sent messages -- please try updating to this one, and turn threading off and on.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 04, 2015, 07:23:13 pm
Kostya,

I encountered a problem that a message that should belong to a "thread" was not added to it. Here is the sequence of event that lead to it:

Participants: G1, G2 (both Gmail accounts), and StR (non-Gmail account, alpine client on Unix for sending the message)
Aquamail: no smart folder enabled, everything is happening within one account, messages are in Inbox, except for one as labeled.

Message 1 (M1):  G1: message to G2, StR, other recipients
Message 2 (M2):  G2: reply to All (to M1)
Message 3 (M3) [in Sent] StR: reply to G1's M1, adding G2 to Cc:

At that point the messages were indexed (and reindexed back and forth a few times during testing).
M1 & M2 showed as a thread.

In a day:
Message 4 (M4): G2: reply to StR's M3, Cc: G1
Aquamail didn't add M4 to the thread {M1,M2}

M4's headers contain:
References: <M1>   <M3>
In-Reply-To: <M3>

Just in case:
M2 has
References: <M1>
In-Reply-to: <M1>

Kostya, I didn't try to turn the conversation view off and on again yet to see if reindexing would pick that message up. I wanted to see if you want me to check anything prior to that.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 04, 2015, 08:18:32 pm
@StR:

Yes, it should have worked when sending M4.

Would it be possible to get actual headers (from Gmail / web presumably) and send them to me at kmansoft / gmail, indicating which is which message (as per your above nomenclature, which I saved)? Plain text file attachment preferred.

I don't need the text parts of any of these messages.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: StR on November 04, 2015, 09:22:46 pm
Sent

Does Aquamail write anything into the message headers upon thread-enabling indexing? I.e. does it require WRITING back on the server (updating the message headers) for that to work?
If yes, - I might have a clue: during the sync with the IMAP server when that message was received, there could've been a "write" lock on the Inbox (on the server side).
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 04, 2015, 09:33:55 pm
Re: does it require WRITING back on the server

NO
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 04, 2015, 11:51:53 pm
@Iceman_jkh

Hmm...

If you do a search, then the results are not threaded (intentional), so I guess when you wrote "I can't find a particular email that was sent (to me) on a certain date" --

-- you meant "I don't see a particular message when scrolling through and looking for it, scanning what's on the screen"?

If so, well, it might happen that the message is "inside" a thread and you're not seeing it?
Exactly. But I'm out of ideas why.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 04, 2015, 11:53:42 pm
Re: Exactly. But I'm out of ideas why

I meant -- the message is linked to a conversation and is "inside", not top level, so you're not seeing it?

Does that explain things?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 05, 2015, 12:28:16 am
Re: Exactly. But I'm out of ideas why

I meant -- the message is linked to a conversation and is "inside", not top level, so you're not seeing it?

Does that explain things?
Yes, it makes sense .. but I'm not seeing any 'similar' messages/conversations. I've tried to look for the subject line, sender and across all possible dates...in case it's within another thread... but still can't find it in conversation mode. I agree it might be 'hiding'. (I just tried latest version, but still the same issue)

Sent from my SM-G920F using Tapatalk

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 05, 2015, 12:43:40 am
Is it a sent message?

Or a received message?

Does it show if you search its respective folder (which one)?

And finally, did you enable "across folders" (just below "conversation view") which pulls up sent messages when viewing an incoming folder and vice versa?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 05, 2015, 01:07:19 am
Is it a sent message?

Or a received message?

Does it show if you search its respective folder (which one)?

And finally, did you enable "across folders" (just below "conversation view") which pulls up sent messages when viewing an incoming folder and vice versa?

It's both. http://www.aqua-mail.com/forum/index.php?topic=4086.msg21642.msg#21642 hopefully explains the situation.

It does show in the Sent and Inbox (for the msg I sent and received, respectively)

Yes, I've enabled it.

Sent from my SM-G920F using Tapatalk
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 05, 2015, 01:15:09 am
Yes, I read that posting and re-read it just now.

All messages should be linked together, but since the subjects are different -- in conversation view, you may see "subject two" and when you expand it, your "subject one" may be one of the children.

That would be my expectation based what "history" you described.

Also worth noting -- "across folders" only pulls in actually references messages.

So if you're looking at "inbox" it will have all messages *in* Inbox, and any Sent messages referenced by (linked with) the account's Sent messages. But it won't have all Sent messages.

Conversely, viewing the Sent folder's message list will show all Sent messages and any incoming messages (in all incoming folders) referenced by these sent messages. But it won't show all incoming messages.


Did I manage to make it even more confusing now?
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 05, 2015, 12:18:45 pm
Yes, I read that posting and re-read it just now.

All messages should be linked together, but since the subjects are different -- in conversation view, you may see "subject two" and when you expand it, your "subject one" may be one of the children.

That would be my expectation based what "history" you described.
That's what I expected. You explained well :)

Quote
Also worth noting -- "across folders" only pulls in actually references messages.

So if you're looking at "inbox" it will have all messages *in* Inbox, and any Sent messages referenced by (linked with) the account's Sent messages. But it won't have all Sent messages.

Conversely, viewing the Sent folder's message list will show all Sent messages and any incoming messages (in all incoming folders) referenced by these sent messages. But it won't show all incoming messages.


Did I manage to make it even more confusing now?

:p No, I think you did fine :)

So, to be clearer.. I've looked in Inbox (for that account and Smart folder) as well as sent folder (for that account) and not found those emails/convo.
I did look for both subject one and subject two emails, as well as emails which were of that approx sent/received date.

I'll try again on a future version (as dev progresses) and I might think of new ideas for how to find the msgs, which I can report back and help identify WHY I couldn't find them (or at least why I believed they should have been shown).
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 05, 2015, 05:08:56 pm
Just wanted to let you know... I found those msgs ☺

They're located within (what I feel is) a completely different conversation. I'll take a proper look and get some better information for you tomorrow.

Sent from my SM-G920F using Tapatalk

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 05, 2015, 05:10:47 pm
Ah, so they're not missing completely after all. That's good to know.

Re: They're located within (what I feel is) a completely different conversation. I'll take a proper look and get some better information for you tomorrow.

It would help me to see message headers for this message and the ones it linked with:

Message-ID
In-Reply-To
References
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 05, 2015, 11:51:07 pm
Ah, so they're not missing completely after all. That's good to know.

Re: They're located within (what I feel is) a completely different conversation. I'll take a proper look and get some better information for you tomorrow.

It would help me to see message headers for this message and the ones it linked with:

Message-ID
In-Reply-To
References

If I PMed a screenshot of the message list view of the group, would that help?
I can't provide this until tonight (after work).

Sent from my SM-G920F using Tapatalk

Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Kostya Vasilyev on November 05, 2015, 11:58:41 pm
Actually I'm going to post another -dev version a bit later tonight, can you install, rebuild thread data (via settings -> message list) and see how it plays out?

If it's still there, can you send me the relevant info -- by email -- to kmansoft / gmail?

Forum PM's are not my thing, sorry.
Title: Re: 1.6.0-14-dev1 - Conversation View - Группировка сообщений
Post by: Iceman_jkh on November 06, 2015, 10:16:06 am
Actually I'm going to post another -dev version a bit later tonight, can you install, rebuild thread data (via settings -> message list) and see how it plays out?

If it's still there, can you send me the relevant info -- by email -- to kmansoft / gmail?

Forum PM's are not my thing, sorry.

Email sent :)