AquaMail Forum

English - Android => Bug reports => Topic started by: hlorri on February 23, 2016, 11:07:31 pm

Title: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: hlorri on February 23, 2016, 11:07:31 pm
Hi, this is my first post in this forum, though I am a long-time and extremely happy AquaMail user.  Keep up the good work. :)

I love that you can use rich text/HTML when composing messages, and even more so that you can create HTML signatures!  In doing so, however, I ran across this little bug.

I want to include my work and mobile numbers as "tel:" links.  The following link gets properly created in Outlook for Mac:
    tel:+1-650-555-1212
However, when I try the same in AquaMail (Accounts -> (Long press Account) -> Options and Folders -> Composing and Sending -> Signature), the mail gets sent with the following link:
    http : //tel:+1-650-555-1212
(Ignore the spaces, I had to insert them to get this post accepted in this forum).


There's a workaround that mostly works, depending on the recipient's email client: The link tel://+1-650-555-1212/ does get inserted correctly.  However, it would be better to not have to insert the extra slashes for compatibility reasons.

Hopefully this can be addressed at some point.  It's a minor issue, but nonetheless fixing it would make AquaMail even more perfect.  :)
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: StR on February 24, 2016, 05:24:22 pm
  hhlori: what is your app's version?
I just tried entering just one line in the signature:
 tel:+1-615-555-1212
Then clicked on rich text and saved.

 It worked properly.

This is a non-Gmail account.
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: mikeone on February 24, 2016, 10:13:59 pm
  hhlori: what is your app's version?
I just tried entering just one line in the signature:
 tel:+1-615-555-1212
Then clicked on rich text and saved.

 It worked properly.

This is a non-Gmail account.
Just tried entering the following line in the signature:

         tel:+1-615-555-1212

... without setting a (hyper) link
[screenshot #1]

It worked properly (long press on phone number in received message)
[screenshot #2 + #3]
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: mikeone on February 24, 2016, 10:37:19 pm
Same signature

tel:+1-615-555-1212

... but setting a (hyper) link:

         +1-615-555-1212

[screenshot #1 + #2]

This forces an issue (long press on phone number in received message)
http://+1-615-555-1212
[screenshot #3 + #4]
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: StR on February 24, 2016, 10:45:44 pm
I suspect that "setting the hyperlink" is intended for setting http:// only, and not any other types of URIs.

I had a chance of looking at the raw message that was sent with the signature set as I described above, and I see that the message is in plain text (Content-Type: text/plain; charset="us-ascii"; format=flowed), despite the "rich text" format.
And no tel: URI (link) is set, it is just Aquamail interpreting it on the receiving side.

I am not sure how things were intended here by Kostya, just reporting the observations.
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: mikeone on February 24, 2016, 10:51:42 pm
... setting a specific link:

         tel:+1-615-555-1212

[screenshot #1 + #2]

is working fine  ;D
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: hlorri on February 25, 2016, 01:36:01 am
... but setting a (hyper) link:

         +1-615-555-1212

[screenshot #1 + #2]

This forces an issue (long press on phone number in received message)
http://+1-615-555-1212

Yup, that's what I meant.  I prefer not to include the "tel:" portion in the "visible" part of the message, so it should look like this:
    +1-650-555-1212

with the link pointing to:
    tel:+1-650-555-1212.

Again - not a showstopper by any means, just a minor annoyance.

Thanks again.
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: mikeone on February 25, 2016, 01:51:37 am
This should be easy:

Enter the following line in the signature:

         +1-615-555-1212

[screenshot #1]

mark the phone number and set a specific link:

         tel:+1-615-555-1212

[screenshot #2]

Just tested: it's working ( long press on phone number in received message) - at least in AquaMail
[screenshot #3]
Title: Re: "tel:" links with leading "+" get mangled to "http://tel:"
Post by: Kostya Vasilyev on February 25, 2016, 04:02:19 pm
The link dialog (the code behind it actually) defaults to http:// scheme unless one is entered.

I just added a check for "starts with +, must be a phone number, add tel: instead".